Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing dark and light mode features in this website. #19

Closed
wants to merge 1 commit into from

Conversation

Amarkr1717
Copy link

@Amarkr1717 Amarkr1717 commented Jan 18, 2025

Description: Add functionality to switch between dark mode and light mode. Ensure proper color contrast and accessibility.

Hi @Parnab03 ,
I’ve resolved the issue mentioned in #5 which is " Implement Dark Mode and Light Mode" . Please review my PR at your convenience. Let me know if any changes or updates are needed.
Thank you!

My motivation behind solving this issue is testing my JavaScript knowledge and want to apply it.


Type of Change

  • ☑️ 🆕 New Feature
  • 🐛 Bug Fix
  • 🖼 Wallpaper Added
  • 🎨 UI/Design Update
  • 🔄 Refactor/Code Improvement
  • 📂 Other (Specify here):

Issue Linked:
Issue no #5


Checklist

  • ☑️ 📖 I have read and followed the Contributing Guidelines.
  • ☑️ ✅ My code adheres to the project's style guidelines.
  • ☑️ 🧪 I have tested my changes locally and ensured no existing functionality is broken.
  • ☑️ ✍️ I have added or updated necessary documentation where applicable (e.g., README.md, DESIGN.md, WALLPAPER.md).

Additional Notes:

You can see the result here:
https://github.com/user-attachments/assets/b0cdad5b-e07f-4f48-b0ae-58a9270b0e76

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks @Amarkr1717 for your PR! A maintainer will review it shortly. We appreciate your contribution!

@Parnab03
Copy link
Owner

@Amarkr1717 Thanks for your concern, but we can't merge this PR because currently we are accepting WoC 4.0 contribution only, so if you are a candidate of WoC 4.0 then submit a proposal on devfolio and join the Discord server, if not then wait for couple of months this project will accept other contributions also
Thank you!

@Parnab03 Parnab03 closed this Jan 19, 2025
@Amarkr1717
Copy link
Author

Amarkr1717 commented Jan 19, 2025

Hey @Parnab03 , I am also a WoC 4.0 contributer, and today I submitted my proposal on devfolio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants